Skip to content

Update the options' descriptions of the neo4j-admin commands according to the code #1852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 11, 2024
Merged

Update the options' descriptions of the neo4j-admin commands according to the code #1852

merged 9 commits into from
Oct 11, 2024

Conversation

@NataliaIvakina
Copy link
Collaborator

@NataliaIvakina NataliaIvakina commented Oct 8, 2024 •
edited
Loading

@NataliaIvakina NataliaIvakina changed the title Update the --schema description according to the code Update the options' descriptions of the neo4j-admin import command according to the code Oct 9, 2024
@NataliaIvakina NataliaIvakina changed the title Update the options' descriptions of the neo4j-admin import command according to the code Update the options' descriptions of the neo4j-admin commands according to the code Oct 9, 2024
@renetapopova renetapopova self-requested a review October 9, 2024 10:42
renetapopova
renetapopova reviewed Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. I am just concerned that we are mentioning the versions in the code. In 2025.01, we'll need to remove them just like the labels. I think a better practice is to keep the code clean and leave all labels to the docs.

NataliaIvakina
NataliaIvakina commented Oct 10, 2024
View reviewed changes
@renetapopova
Copy link
Collaborator

Could you please update the descriptions as per https://github.com/neo-technology/neo4j/pull/27550? I'll then rebase the Parket PR and see if the test there will fail again.

@NataliaIvakina
Copy link
Collaborator Author

Could you please update the descriptions as per neo-technology/neo4j#27550? I'll then rebase the Parket PR and see if the test there will fail again.

yes, sure. I'll do that

NataliaIvakina
NataliaIvakina commented Oct 10, 2024
View reviewed changes
@NataliaIvakina
Copy link
Collaborator Author

I've updated according to the latest PR. But they forgot to update --relationships=[<type>=]<files>... in the Import section

NataliaIvakina
NataliaIvakina commented Oct 10, 2024
View reviewed changes
NataliaIvakina
NataliaIvakina commented Oct 11, 2024
View reviewed changes
NataliaIvakina
NataliaIvakina commented Oct 11, 2024
View reviewed changes
@neo-technology-commit-status-publisher
Copy link
Collaborator

neo-technology-commit-status-publisher commented Oct 11, 2024 •
edited
Loading

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@NataliaIvakina NataliaIvakina merged commit 9ad1096 into neo4j:dev Oct 11, 2024
7 of 8 checks passed
@NataliaIvakina NataliaIvakina deleted the dev-schema-option-desc branch October 11, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@renetapopova renetapopova renetapopova left review comments

Assignees

No one assigned

Labels

5.25

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NataliaIvakina @renetapopova @neo-technology-commit-status-publisher