Allow parameters in CREATE/ALTER DATABASE TOPOLOGY

[l-heemann]

Document this change: https://github.com/neo-technology/neo4j/pull/27665

[l-heemann]

Allow parameters in CREATE DATABASE TOPOLOGY

[HannesSandberg]

I wonder if this is overkill. We don't mention that the name could be a parameter. Maybe enough to add a second example to the create example. Something like:

CREATE DATABASE foo TOPOLOGY 3 PRIMARIES 2 SECONDARIES

or with parameters

{
  "dbname": "foo",
  "primary": 1,
  "secondary": 2
}

CREATE DATABASE $dbName TOPOLOGY $primary PRIMARIES $secondary SECONDARIES

[renetapopova]

I think it's useful to have both.

[l-heemann]

Added the dbname 👍

I feel like it would be overkill to have one parameter example for create and another for alter alter, by mentioning ALTER in the text we get away with only the one. Let me know if you'd prefer the or with parameters approach with one for create and one for alter 🤷

[renetapopova]

I think a better practice is to keep them separate because whoever is looking for how to alter a database won't be looking at the create a database section. Of course, they might find a way to the example, but nobody reads the docs from top to bottom. A workaround could be to mention the feature, from when it is supported, etc., in the alter section and then refer to the create section, but it might be even more complicated.

[renetapopova]

I added some suggestions. Thanks, @l-heemann

[renetapopova]

Also, which version is this PR applicable to? I guess it's 5.26.

[l-heemann]

I guess it's 5.26

Yes 👍

[renetapopova]

Suggested change

	The `CREATE DATABASE` and `ALTER DATABASE` commands support the usage of link:{neo4j-docs-base-uri}/cypher-manual/{page-version}/syntax/parameters[parameters] when providing the database, the number of primaries and/or the number of secondaries.
	The `CREATE DATABASE` and `ALTER DATABASE` commands support the usage of link:{neo4j-docs-base-uri}/cypher-manual/{page-version}/syntax/parameters[parameters] when providing the database, the number of primaries, and/or the number of secondaries.

[renetapopova]

Missing Oxford comma.

[l-heemann]

No longer applicable, I think

[renetapopova]

I think a better practice is to keep them separate because whoever is looking for how to alter a database won't be looking at the create a database section. Of course, they might find a way to the example, but nobody reads the docs from top to bottom. A workaround could be to mention the feature, from when it is supported, etc., in the alter section and then refer to the create section, but it might be even more complicated.

[l-heemann]

Corresponding changelog in docs-cypher: neo4j/docs-cypher#1082

[l-heemann]

I think a better practice is to keep them separate because whoever is looking for how to alter a database won't be looking at the create a database section. Of course, they might find a way to the example, but nobody reads the docs from top to bottom. A workaround could be to mention the feature, from when it is supported, etc., in the alter section and then refer to the create section, but it might be even more complicated.

Makes sense, I've split it up similar to Hannes' first suggestion, let me know what you think.

[renetapopova]

The examples look good. I added a suggestion for the sentence before them.

[neo-technology-commit-status-publisher]

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

[renetapopova]

Thanks, @l-heemann. I think it looks good now.

[HannesSandberg]

lgtm 👍