Skip to content

Update config settings #1923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2024
Merged

Update config settings #1923

merged 1 commit into from
Nov 1, 2024

Conversation

@NataliaIvakina
Copy link
Collaborator

@NataliaIvakina NataliaIvakina commented Oct 29, 2024 •
edited
Loading

@neo-technology-commit-status-publisher
Copy link
Collaborator

neo-technology-commit-status-publisher commented Oct 29, 2024 •
edited
Loading

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@renetapopova renetapopova self-requested a review October 29, 2024 09:39
renetapopova
renetapopova reviewed Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two dbms.cluster.minimum_initial_system_primaries_count and server.directories.cluster_state also look like deprecated from 5.26.
dbms.cluster.network.supported_compression_algos has a changed value from emptyList to List.of, but I don't know how this will be rendered in SHOW CONFIG.

@NataliaIvakina
Copy link
Collaborator Author

These two dbms.cluster.minimum_initial_system_primaries_count and server.directories.cluster_state also look like deprecated from 5.26. dbms.cluster.network.supported_compression_algos has a changed value from emptyList to List.of, but I don't know how this will be rendered in SHOW CONFIG.

I'll take a look. I'll also ask someone from the clustering to review this PR when time comes to push all 5.26 changes

@NataliaIvakina
Copy link
Collaborator Author

I might be wrong but dbms.cluster.minimum_initial_system_primaries_count and server.directories.cluster_state are not deprecated in 5.26. Only the use of the port 5000 is deprecated (see the file).

@NataliaIvakina
Copy link
Collaborator Author

dbms.cluster.network.supported_compression_algos has a changed value from emptyList to List.of, but I don't know how this will be rendered in SHOW CONFIG.

We don't have any default value for this config.
But I'll double check this moment when asking for a technical review

@renetapopova
Copy link
Collaborator

I might be wrong but dbms.cluster.minimum_initial_system_primaries_count and server.directories.cluster_state are not deprecated in 5.26. Only the use of the port 5000 is deprecated (see the file).

Ah, I see now. Sorry for the confusion.

@NataliaIvakina NataliaIvakina requested a review from tonbut October 31, 2024 08:22
tonbut
tonbut approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@tonbut tonbut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@renetapopova renetapopova merged commit c651079 into neo4j:dev Nov 1, 2024
8 checks passed
@NataliaIvakina NataliaIvakina deleted the dev-fix-config-failing-test branch January 14, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@renetapopova renetapopova renetapopova left review comments

@tonbut tonbut tonbut approved these changes

Assignees

No one assigned

Labels

5.26

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NataliaIvakina @neo-technology-commit-status-publisher @renetapopova @tonbut