Skip to content

Conversation

@NataliaIvakina
Copy link
Collaborator

@NataliaIvakina NataliaIvakina commented Oct 29, 2024

Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Misha should review this one, just to be aware that we're documenting an MVCC metric.

@NataliaIvakina
Copy link
Collaborator Author

NataliaIvakina commented Oct 29, 2024

I think Misha should review this one, just to be aware that we're documenting an MVCC metric.

Yes, of course. I'll tag him as a reviewer later. By the way, we have already one MVCC related metric in the docs -
<prefix>.transaction.validation_failure.

@NataliaIvakina NataliaIvakina changed the title Add a MVCC related metric Add an MVCC related metric Oct 29, 2024
@MishaDemianenko
Copy link
Contributor

Hi folks, so I have a question. MVCC is not released even for beta users atm and there is no mentioning of that in any other parts of docs. Is it okay to have those metrics described in public documentation for a feature that does not exist yet give or take?

@NataliaIvakina
Copy link
Collaborator Author

Hi folks, so I have a question. MVCC is not released even for beta users atm and there is no mentioning of that in any other parts of docs. Is it okay to have those metrics described in public documentation for a feature that does not exist yet give or take?

@renetapopova, @stefano-ottolenghi, considering we already have one MVCC-related metric in the documentation, what do you think?

@stefano-ottolenghi, is it possible to comment out those metrics in the docs (to hide them from users for some time)? Will it break our test?

@stefano-ottolenghi
Copy link
Contributor

Will it break our test?

It will, because they are publicly available metrics. We can add a fence to explicitly exclude them until we want to surface them, if there's a need for that (but then the question is: why are they not in the internal namespace?).

@neo-technology-commit-status-publisher
Copy link
Collaborator

neo-technology-commit-status-publisher commented Nov 11, 2024

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@NataliaIvakina NataliaIvakina merged commit 9c52429 into neo4j:dev Nov 12, 2024
8 checks passed
@NataliaIvakina NataliaIvakina deleted the dev-add-metrics branch November 12, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants