-
Notifications
You must be signed in to change notification settings - Fork 83
Add an MVCC related metric #1924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Misha should review this one, just to be aware that we're documenting an MVCC metric.
Yes, of course. I'll tag him as a reviewer later. By the way, we have already one MVCC related metric in the docs - |
|
Hi folks, so I have a question. MVCC is not released even for beta users atm and there is no mentioning of that in any other parts of docs. Is it okay to have those metrics described in public documentation for a feature that does not exist yet give or take? |
@renetapopova, @stefano-ottolenghi, considering we already have one MVCC-related metric in the documentation, what do you think? @stefano-ottolenghi, is it possible to comment out those metrics in the docs (to hide them from users for some time)? Will it break our test? |
It will, because they are publicly available metrics. We can add a fence to explicitly exclude them until we want to surface them, if there's a need for that (but then the question is: why are they not in the |
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
see https://github.com/neo-technology/neo4j/commit/758960863da689d7b47d6562037e4bd4ea4259cb#diff-824ff32f02805ec284d529daf30fe070bcd5f58a3c7be32bced227fa75c43c7b