Skip to content

add note about database name in query log #1980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 26, 2024
Merged

add note about database name in query log #1980

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1770979
add note about database name in query log
LinneaAndersson Nov 22, 2024
69458d8
editorial suggestions
LinneaAndersson Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/ROOT/pages/monitoring/logging.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1221,7 +1221,7 @@ Included when xref:configuration/configuration-settings.adoc#config_db.logs.quer
| Connection details.

| database
| The database name on which the query is run.
| The database name on which the query is run. This field will be `<none>` if it is not possible to parse and route the query to the correct database.
Copy link
Collaborator

@renetapopova renetapopova Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| The database name on which the query is run. This field will be `<none>` if it is not possible to parse and route the query to the correct database.
| The database name on which the query is run. This field will be `<none>` if it is impossible to parse and route the query to the correct database.

Copy link

@htsedebenham htsedebenham Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another editorial suggestion - "route the query to a database" instead of "route a query to the correct database" - I would argue that there might be other reasons a query might not be routed to the user's definition of "correct"!

Copy link
Contributor Author

@LinneaAndersson LinneaAndersson Nov 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason it felt wrong to say impossibe (don't ask me why 😄). Would it be okay with the change I made to:

"This field will be <none> if the query cannot be parsed and routed to a database."


| executingUser
| The name of the user executing the query.
Expand Down