-
Notifications
You must be signed in to change notification settings - Fork 83
Add inspect backup recovered column #2363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@yirensum, is this addition for 2025.06 (June) release? I found your PR https://github.com/neo-technology/neo4j/pull/31101. It was merged last week. |
|
Hey yes that's right, it's in the next release |
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
| * *Compressed*: indicates whether the backup data inside the backup file is compressed. | ||
| * *Lowest transaction ID*: when the backup is full, this value is always 1, and when it is a differential backup, the value corresponds to the first transaction ID the backup starts with. | ||
| * *Highest transaction ID*: similarly, this value indicates the last transaction ID stored in the backup file. | ||
| * label:new[Introduced in 2025.06] *Recovered*: shows whether a database backup is recovered or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yirensum, hey! I think everything looks good. One question: Do we need to explain the meaning of this column?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! I think we are ok not to explain it for now, it's more for our internal usage.
We currently have an internal feature flag for backup which allow recovery to be skipped - when we make this public, then maybe it's worth adding information along with that.
NataliaIvakina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will approve this PR, but please do not merge till 2025.05 is published
We added a new column recently in the inspect command, and this is to update the docs to be in line with that --------- Co-authored-by: sumyiren <[email protected]> Co-authored-by: NataliaIvakina <[email protected]>
We added a new column recently in the inspect command, and this is to update the docs to be in line with that