Skip to content

Added superfluous optional notification #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 17, 2024
Merged

Added superfluous optional notification #175

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
32ddb86
Added superfluous optional notification
JoelBergstrand Sep 4, 2024
ca80cfe
Split notifications
JoelBergstrand Sep 6, 2024
1ca8934
Apply suggestions from code review
JoelBergstrand Sep 9, 2024
3d6363c
Added GQLstatus tabs
JoelBergstrand Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions modules/ROOT/pages/changelogs.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
:description: This page lists all changes to status codes per Neo4j version.
= Changes to status codes per Neo4j version

== Neo4j 5.24

**New:**

[source, status codes, role="noheader"]
-----
Neo.ClientNotification.Statement.SuperfluousOptional
-----

== Neo4j 5.23

From version 5.23, Neo4j has a new GqlStatusObject API in addition to the existing Notification API.
Expand Down
24 changes: 24 additions & 0 deletions modules/ROOT/pages/notifications/all-notifications.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3544,6 +3544,30 @@ RETURN *
======
=====

[#_neo_clientnotification_statement_superfluousoptional]
=== Superfluous Optional
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
=== Superfluous Optional
=== Superfluous optional


.Notification details
[cols="<1s,<4"]
|===
|Neo4j code
m|Neo.ClientNotification.Statement.SuperfluousOptional
|Title
a|The use of OPTIONAL is superfluous when `CALL` is a unit subquery or a void procedure.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
a|The use of OPTIONAL is superfluous when `CALL` is a unit subquery or a void procedure.
a|The use of `OPTIONAL` is superfluous when `CALL` is a unit subquery or a void procedure.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also be changed in the code if we change it here.

|Description
|The use of OPTIONAL is superfluous when `CALL` is a unit subquery or a void procedure.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
|The use of OPTIONAL is superfluous when `CALL` is a unit subquery or a void procedure.
|The use of `OPTIONAL` is superfluous when `CALL` is a unit subquery or a void procedure.

|Category
m|GENERIC
|GQLSTATUS code
m|03N61
|Status description
a|info: superfluous optional. The use of optional is superfluous when `CALL` is a unit subquery or a void procedure.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
a|info: superfluous optional. The use of optional is superfluous when `CALL` is a unit subquery or a void procedure.
a|info: superfluous optional. The use of `OPTIONAL` is superfluous when `CALL` is a unit subquery or a void procedure.

|Classification
m|GENERIC
|SeverityLevel
m|INFORMATION
|===

[#_neo_clientnotification_statement_parameternotprovided]
=== Parameter missing

Expand Down