Skip to content

Conversation

@renetapopova
Copy link
Collaborator

No description provided.

Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress, just some minor things I found.

[[transaction-rollback]]
== Transaction rollback
Transaction rollback errors occur when the transaction is rolled back due to an error, such as when the transaction rollback fails, or when the constituent rollback fails.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence is a little bit hard to understand. Maybe it is just my lacking English, but to me it sounds a bit like the transaction was rolled back because of an error and that error was that the rollback failed. That cannot be the intended meaning though, because that would be a circle dependency.

@renetapopova renetapopova requested a review from Lojjs October 18, 2024 07:08
@neo-technology-commit-status-publisher
Copy link
Collaborator

neo-technology-commit-status-publisher commented Oct 18, 2024

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

@renetapopova renetapopova merged commit 6da3081 into neo4j:gqlstatus-errors Oct 21, 2024
5 checks passed
@renetapopova renetapopova deleted the gql-batch-2 branch October 21, 2024 08:04
renetapopova added a commit that referenced this pull request Oct 31, 2024
Co-authored-by: Louise Berglund <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants