- 
                Notifications
    You must be signed in to change notification settings 
- Fork 35
Add 25, 2D, and 42 codes #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 25, 2D, and 42 codes #191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great progress, just some minor things I found.
Co-authored-by: Louise Berglund <[email protected]>
Co-authored-by: Louise Berglund <[email protected]>
3539a61    to
    e8393ce      
    Compare
  
    | [[transaction-rollback]] | ||
| == Transaction rollback | ||
| Transaction rollback errors occur when the transaction is rolled back due to an error, such as when the transaction rollback fails, or when the constituent rollback fails. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence is a little bit hard to understand. Maybe it is just my lacking English, but to me it sounds a bit like the transaction was rolled back because of an error and that error was that the rollback failed. That cannot be the intended meaning though, because that would be a circle dependency.
Co-authored-by: Louise Berglund <[email protected]>
Co-authored-by: Louise Berglund <[email protected]>
| Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now
Co-authored-by: Louise Berglund <[email protected]>
No description provided.