Skip to content

Conversation

@renetapopova
Copy link
Collaborator

No description provided.

Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments, rest looks good.

Comment on lines +956 to +959
=== 42NA6

Status description:: info: invalid alias target. Aliases are not allowed to target composite databases.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is totally different between the codebase and the spreadsheet, not even about the same topic 😅 Do you know when it was changed and can verify which is correct @anderson4j and @WilcoNeo ?

Copy link
Contributor

@WilcoNeo WilcoNeo Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not change this code as far a I can see.
To me it looks like this one is more correct than what is currently in the code.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lojjs, @WilcoNeo, shall I merge this PR as is?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes looking as the usage, it looks like the codebase is wrong and docs and spreadsheet is correct. I will make a card to update the codebase

@neo-technology-commit-status-publisher
Copy link
Collaborator

neo-technology-commit-status-publisher commented Nov 6, 2024

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can merge now, thanks

@renetapopova renetapopova merged commit 030024e into neo4j:gqlstatus-errors Nov 11, 2024
5 checks passed
@renetapopova renetapopova deleted the gql-batch3 branch November 11, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants