Skip to content

Final surface codes #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 1, 2025
Merged

Final surface codes #301

merged 8 commits into from
May 1, 2025

Conversation

@JoelBergstrand
Copy link
Contributor

Codes needed to cover errors left over in deperected constructors. Monorepo PR.

@JoelBergstrand JoelBergstrand added the dev The default branch. label Apr 23, 2025
@JoelBergstrand JoelBergstrand force-pushed the final-surface-codes branch 2 times, most recently from e74650d to 66a3ddc Compare April 23, 2025 14:28
@renetapopova renetapopova self-requested a review April 25, 2025 08:13
renetapopova
renetapopova requested changes Apr 25, 2025
View reviewed changes
Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @JoelBergstrand. You also need to add these errors to the modules/ROOT/pages/errors/gql-errors/index.adoc and modules/ROOT/content-nav.adoc.

@JoelBergstrand
Copy link
Contributor Author

@renetapopova 42I53 was missing from the gql-errors/index. Added it there in this PR.

@Lojjs
Copy link
Contributor

Lojjs commented Apr 28, 2025

@renetapopova 42I53 was missing from the gql-errors/index. Added it there in this PR.

Just FYI, as one of you might get a conflict. I think @NataliaIvakina noted and fixed the same thing here #299

@renetapopova
Copy link
Collaborator

@renetapopova 42I53 was missing from the gql-errors/index. Added it there in this PR.

It's added in two other PRs as well.

renetapopova
renetapopova approved these changes Apr 28, 2025
View reviewed changes
Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll rebase it and merge it. Thanks, @JoelBergstrand

@JoelBergstrand
Copy link
Contributor Author

Thanks @renetapopova!

@renetapopova
Copy link
Collaborator

@JoelBergstrand, I see that the PR in the monorepo has not been merged, so I guess this PR needs to wait for the 2025.05 release.

@JoelBergstrand
Copy link
Contributor Author

@renetapopova now the code PR is merged.

@renetapopova
Copy link
Collaborator

@renetapopova now the code PR is merged.

Thanks, @JoelBergstrand. I'll merge it after we publish the 2025.04 release, as dev now is 2025.04.

@renetapopova renetapopova force-pushed the final-surface-codes branch from 912092e to 4943883 Compare May 1, 2025 13:22
@renetapopova renetapopova force-pushed the final-surface-codes branch from 4943883 to eff512a Compare May 1, 2025 13:24
@neo4j-docops-agent
Copy link
Collaborator

neo4j-docops-agent commented May 1, 2025 •
edited
Loading

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@renetapopova renetapopova merged commit 93f19db into neo4j:dev May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@renetapopova renetapopova renetapopova approved these changes

Assignees

No one assigned

Labels

2025.05 dev The default branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JoelBergstrand @Lojjs @renetapopova @neo4j-docops-agent