Skip to content

Conversation

@evelinadanielsson
Copy link
Contributor

Adding notification and status code 01N74 introduced in this PR

@evelinadanielsson evelinadanielsson marked this pull request as draft October 2, 2025 15:05
@evelinadanielsson evelinadanielsson marked this pull request as ready for review October 2, 2025 15:05
@mnd999 mnd999 added the dev The default branch. label Oct 2, 2025
@renetapopova renetapopova self-assigned this Oct 2, 2025
@l-heemann l-heemann self-assigned this Oct 6, 2025
Copy link
Contributor

@l-heemann l-heemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a suggestion. Is dbms.security.allow_oidc_credential_forwarding_enabled a new configuration setting? If yes, we need to document it in the Operations manual.

@renetapopova renetapopova force-pushed the dev-credential-forwarding-01N74 branch from d0225de to 35325d6 Compare October 21, 2025 10:00
Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @evelinadanielsson. I added a suggestion.


Suggestions for improvement::
Enable OIDC credential forwarding through the `dbms.security.allow_oidc_credential_forwarding_enabled` setting.
Until enabled, all access attempts to the new remote database alias will fail.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Until enabled, all access attempts to the new remote database alias will fail.

----

Suggestions for improvement::
Enable OIDC credential forwarding through the `dbms.security.allow_oidc_credential_forwarding_enabled` setting.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Enable OIDC credential forwarding through the `dbms.security.allow_oidc_credential_forwarding_enabled` setting.
Enable OIDC credential forwarding through the `dbms.security.allow_oidc_credential_forwarding_enabled` setting to gain access to the remote database alias.

Use the setting 'dbms.security.allow_oidc_credential_forwarding_enabled' to enable OIDC credential forwarding.

Suggestions for improvement::
Enable OIDC credential forwarding through the `dbms.security.allow_oidc_credential_forwarding_enabled` setting.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Enable OIDC credential forwarding through the `dbms.security.allow_oidc_credential_forwarding_enabled` setting.
Enable OIDC credential forwarding through the `dbms.security.allow_oidc_credential_forwarding_enabled` setting to gain access to the remote database alias.


Suggestions for improvement::
Enable OIDC credential forwarding through the `dbms.security.allow_oidc_credential_forwarding_enabled` setting.
The remote database alias has been created successfully, however all attempts to access it will fail, unless the setting is enabled.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The remote database alias has been created successfully, however all attempts to access it will fail, unless the setting is enabled.

@evelinadanielsson evelinadanielsson force-pushed the dev-credential-forwarding-01N74 branch from 8ec1964 to 6496f96 Compare October 22, 2025 15:03
@evelinadanielsson evelinadanielsson force-pushed the dev-credential-forwarding-01N74 branch from 6496f96 to f4cfef5 Compare October 22, 2025 15:05
@neo4j-docops-agent
Copy link
Collaborator

neo4j-docops-agent commented Oct 22, 2025

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @evelinadanielsson. Looks good, I have added just one question.

@renetapopova renetapopova self-requested a review October 28, 2025 10:10
Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you both.

@renetapopova renetapopova merged commit 67d0942 into neo4j:dev Oct 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2025.10 dev The default branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants