Document new error codes for vector search filtering.

[Lojjs]

No description provided.

[renetapopova]

Thanks, @Lojjs. I pushed some editorial updates, but I also left some suggestions that I am not sure are correct. Please take a look.

[dogofbrian]

Nice. Just some typos and a couple of suggestions.

[arnefischereit]

It may not be clear what an "additional" property is, depending on how we called this in the original docs (I have not seen that).

[Lojjs]

I asked @Hunterness about this in another comment thread. She is writing those docs today so we will update this if she ends up calling them something else, additional property is what the concept is called in her CIP

[Hunterness]

I have just added a PR for my bits, currently using 'additional property' but we'll see what reviewers say

[Lojjs]

Question for both of you @Hunterness and @arnefischereit: I noticed we ended up using "additional property for filtering" consistently in the docs. Do you think adding the "for filtering" to the error text as well would be an improvement?

[Hunterness]

I know I've called them both (usually dropping the "for filtering" when I want a short hand/already said that further up the page)

error: data exception - wrong property for vector search filtering. The property { <<propKey>> } is not an additional property for filtering of the vector index { <<idx>> }.

that sounds a bit repetitive and hard to read though

[arnefischereit]

While I think I do agree with @Hunterness that this sound rather redundant, I found a lot of the error messages structured {subCondition}. {message} to be repetitive.

In this case, I think that maybe that should be the case and we should make it even more so:

The property ... is not an additional property on ... for vector search filtering.

[Lojjs]

@arnefischereit @Hunterness Coming back to this PR now when the general Cypher SEARCH docs are finished.

In the last suggestion, where you thinking it should say

error: data exception - wrong property for vector search filtering. The property is not an additional property on for vector search filtering.

I think that is sounds a bit weird with a property on an index

[Hunterness]

Or is this what Arne is after? (not having the on and filling in the ... with the original bits of the message)

error: data exception - wrong property for vector search filtering. The property { <<propKey>> } is not an additional property of the vector index { <<idx>> } for vector search filtering.

[Lojjs]

I think that sound better, I will go with that unless Arne protest

[Lojjs]

I did the above but changed "vector search filtering" to "vector search with filters" which was what we ended up deciding on with David Pond.

[renetapopova]

Some comments from me.

[renetapopova]

@Lojjs, is this ready for merging? Shall I take a final look?

[renetapopova]

I left a couple of questions.

[neo4j-docops-agent]

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.