Draft
Conversation
✅ Deploy Preview for neo4j-graph-data-science-client canceled.
|
| log_progress: bool = True, | ||
| ) -> WriteBackResult: | ||
| if isinstance(property_overwrites, str): | ||
| # The remote write back procedure allows specifying a single overwrite. The key is ignored. |
Contributor
There was a problem hiding this comment.
And if user provides dict[str, str] are keys also ignored?
| job_id: str, | ||
| remote_write_back_client: RemoteWriteBackClient | None = None, | ||
| ): | ||
| super().__init__(arrow_client, job_id, remote_write_back_client=remote_write_back_client) |
Contributor
There was a problem hiding this comment.
I think due to multiple inheritance in this case only the init method of JobHandle will be called, so remote_write_back_client may not get set?
FlorentinD
reviewed
Jan 30, 2026
Contributor
FlorentinD
left a comment
FlorentinD
left a comment
There was a problem hiding this comment.
I like the general api, only minor comments
| threshold=threshold, | ||
| ) | ||
|
|
||
| job_id = self._node_property_endpoints.run_job("v2/community.wcc", config) |
Contributor
There was a problem hiding this comment.
NIT: maybe we want to name the method start_job instead
| self._client = client | ||
|
|
||
| def stream(self, G: GraphV2) -> DataFrame: | ||
| return JobClient().stream_results(self._client, G.name(), self._job_id) |
Contributor
There was a problem hiding this comment.
dont we need to check the status of the job before streaming?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref GDSA-145