Conversation
…lling - Replace `kubectl delete pv --all` with targeted PV deletion by name to prevent parallel tests from interfering with each other's PVs, which was causing 10-minute timeouts - Fix variable shadowing bug where statefulset existence check result was ignored (always used the namespace check error instead) - Replace fixed time.Sleep calls with waitForPodsTerminated polling - Add runWithRetry and waitForPodsTerminated helper functions Made-with: Cursor
- Add 5-minute context timeout to gcloud run() which previously had no timeout and could hang indefinitely - Fix deleteDisk retry loop that used select/default pattern causing a CPU-burning busy-loop hammering the GCP API with no delay between retries; now sleeps 5 seconds between attempts Made-with: Cursor
The error returned by createPersistentVolume was silently discarded, allowing tests to proceed with a failed PV/PVC setup. Now the error is checked and propagated properly. Made-with: Cursor
Add 50-minute job-level timeout to all four test jobs as a safety net. Without this, the GitHub Actions default of 6 hours applies, meaning a hung process (e.g. kubectl port-forward with no timeout) could burn CI runner time for hours. Made-with: Cursor
kubectl logs on completed/terminated pods can fail transiently.
Add a kubectlLogs helper that retries up to 3 times with 10-second
delays, and replace all raw exec.Command("kubectl", "logs", ...)
calls across standalone.go and cluster.go to use it.
Made-with: Cursor
riggi-alekaj
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix flaky integration tests: scoped cleanup, timeouts and error handling