Skip to content

hide preview in desktop #1987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2024
Merged

hide preview in desktop #1987

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions src/browser/modules/Stream/PlayFrame.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,6 @@ import {
StackPreviousIcon
} from 'browser-components/icons/LegacyIcons'

import docs, { DocItem, isPlayChapter } from '../../documentation'
import Docs from '../Docs/Docs'
import { splitMdSlides } from '../Docs/MD/splitMd'
import FrameAside from '../Frame/FrameAside'
import FrameBodyTemplate from '../Frame/FrameBodyTemplate'
import { ErrorsView } from './CypherFrame/ErrorsView/ErrorsView'
import { AuraPromoLink, PromotionContainer } from './styled'
import { CarouselButton } from 'browser-components/buttons'
import {
splitStringOnFirst,
Expand All @@ -47,7 +40,14 @@ import { isConnectedAuraHost } from 'shared/modules/connections/connectionsDuck'
import { getEdition, isEnterprise } from 'shared/modules/dbMeta/dbMetaDuck'
import { DARK_THEME } from 'shared/modules/settings/settingsDuck'
import { LAST_GUIDE_SLIDE } from 'shared/modules/udc/udcDuck'
import docs, { DocItem, isPlayChapter } from '../../documentation'
import Docs from '../Docs/Docs'
import { splitMdSlides } from '../Docs/MD/splitMd'
import FrameAside from '../Frame/FrameAside'
import FrameBodyTemplate from '../Frame/FrameBodyTemplate'
import { ErrorsView } from './CypherFrame/ErrorsView/ErrorsView'
import PreviewFrame from './StartPreviewFrame'
import { AuraPromoLink, PromotionContainer } from './styled'

const AuraPromotion = () => {
const theme = useContext(ThemeContext)
Expand Down Expand Up @@ -207,7 +207,8 @@ function generateContent(
bus: Bus,
onSlide: any,
shouldUseSlidePointer: boolean,
showPromotion = false
showPromotion = false,
inDesktop = false
): Content | Promise<Content> {
// Not found
if (stackFrame.response && stackFrame.response.status === 404) {
Expand Down Expand Up @@ -289,7 +290,8 @@ function generateContent(
// Check if content exists locally
if (isPlayChapter(guideName)) {
const isPreviewAvailable =
localStorage.getItem('previewAvailable') === 'true'
localStorage.getItem('previewAvailable') === 'true' && !inDesktop

const { content, title, subtitle, slides = null } = chapters[guideName]

const isPlayStart = stackFrame.cmd.trim() === ':play start'
Expand Down Expand Up @@ -383,7 +385,8 @@ const mapStateToProps = (state: GlobalState) => ({
(getEdition(state) !== null &&
!isEnterprise(state) &&
!isConnectedAuraHost(state)) ||
inDesktop(state)
inDesktop(state),
inDesktop: inDesktop(state)
})

export default connect(mapStateToProps)(withBus(PlayFrame))
Loading