Open
Conversation
- Relocated all bookmarks-related code to a new 'bookmarks' package. - Updated references from 'neo4j.Bookmarks' to 'bm.Bookmarks' for clarity and to avoid conflicts. - Adopted 'bm' as a package alias to resolve naming conflicts in functions, like in 'cleanupBookmarks(bookmarks bookmarks.Bookmarks)', to prevent ambiguity. - Added Bookmarks aliases in the neo4j package to maintain backward compatibility. - Renamed 'bookmarkManager' to 'DefaultBookmarkManager' for clearer representation and to avoid naming conflicts.
- Relocated all session config related code to a new 'bookmarks' package. - Add AcessMode type to config package - Add AuthToken type alias to config package
- Move SessionConfig Into new file named session_config - Move AccessMode and its constants into session_config file - Move AuthToken type alias to session_config file
- Relocated all Transaction Config code into the config package and update all references to neo4j.TransactionConfig to config.TransactionConfig
…patibility - Added all required type aliases to the Neo4j package to ensure backward compatibility. - This commit introduces SessionConfig, TransactionConfig, and AccessMode aliases in the Neo4j package.
Contributor
|
@lucapirolo just letting you know I've not forgotten about this package tidy up! I'll be finishing up reviewing this soon and update the PR afterwards. Thanks again for the large contribution 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Made
Refactoring Types to
configPackage:Bookmarkstype and related code into theconfigpackage.TransactionConfigandSessionConfigto theconfigpackage.AccessModeto theconfigpackage.Updating References:
neo4j.toconfig.to reflect the new locations of these types.Introducing Type Aliases for Backward Compatibility: