ProfiledPlan: expose existence for all metrics#687
Draft
robsdedude wants to merge 2 commits intoneo4j:6.xfrom
Draft
ProfiledPlan: expose existence for all metrics#687robsdedude wants to merge 2 commits intoneo4j:6.xfrom
robsdedude wants to merge 2 commits intoneo4j:6.xfrom
Conversation
robsdedude
force-pushed
the
summary/expose-profile-metrics-existence
branch
from
025adba to
8a37b5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing 4 new methods on
ProfiledPlan:HasPageCacheStats() bool: indicating whether the profile recorded page cache stats:PageCacheMissesPageCacheHitsPageCacheHitRatioHasDbHits() bool: indicating whether the profile recordedDbHits.HasRecords() bool: indicating whether the profile recordedRecords(orrowsas they're called on the embedded API).HasTime() bool: indicating whether the profile recordedTime.According to a chat with the Cypher runtime team, the absence of the value is not equivalent to it being zero. Therefore it makes sense to express this information in the API. The information is encoded in the bolt protocol through absence or existence of the respective fields. The driver logic has been changed to use this information instead of checking for fallback zero values.
Closes: DRIVERS-284
Depends on: