-
Notifications
You must be signed in to change notification settings - Fork 170
Improved schema definition in the SimpleKGPipeline #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
stellasia
merged 13 commits into
neo4j:main
from
stellasia:feature/improved-schema-definition
Nov 20, 2024
Merged
Improved schema definition in the SimpleKGPipeline #176
stellasia
merged 13 commits into
neo4j:main
from
stellasia:feature/improved-schema-definition
Nov 20, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/improved-schema-definition # Conflicts: # src/neo4j_graphrag/utils.py
willtai
reviewed
Nov 8, 2024
willtai
reviewed
Nov 8, 2024
…into feature/improved-schema-definition
willtai
approved these changes
Nov 20, 2024
Contributor
willtai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 🛰️
willtai
pushed a commit
to willtai/neo4j-genai-python
that referenced
this pull request
Dec 9, 2024
* some tests * Simplify * Remove SchemaEntity/SchemaRelation as valid inputs in SimpleKGPipeline (not "simple") * Fix mypy * Fix ruff * Ruff again * Ruff again * Update tests, examples and CHANGELOG * Fix mypy again N * Update type, switch to model_validate method due to typing issues * Ruff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to specify some entities or relationships as dict in the SimpleKGPipeline, adding a description and property list (both optional):
Type of Change
Complexity
Complexity: Low
How Has This Been Tested?
Checklist
The following requirements should have been met (depending on the changes in the branch):