Use the neo4j_database parameter everywhere #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into fix/writer-database # Conflicts: # CHANGELOG.md
stellasia
changed the title
alexthomas93
approved these changes
Nov 22, 2024
Contributor
alexthomas93
left a comment
alexthomas93
left a comment
There was a problem hiding this comment.
LGTM. Just had a small comment about the changelog
willtai
approved these changes
Nov 22, 2024
willtai
pushed a commit
to willtai/neo4j-genai-python
that referenced
this pull request
Dec 9, 2024
* Use self.neo4j_database for all queries in Neo4jWriter * Make sure all execute_query can be run against a custom database * Update CHANGELOG * Update docstring + update examples not to use undocumented feature for neo4j driver * Expose neo4j_database in SimpleKGBuilder * Update CHANGELOG * Simplify changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix bug reported in #214
In addition:
neo4j_databaseparameter where it was missing (Text2CypherRetrieverandNeo4jChunkReader)neo4j_databaseparameter inSimpleKGPipelinesince this is the only way to configure it properly.Type of Change
Complexity
Complexity: Low
How Has This Been Tested?
Checklist
The following requirements should have been met (depending on the changes in the branch):