Remove misleading warning about Document node not being created #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willtai
reviewed
Nov 25, 2024
| "No document metadata provided, the document node won't be created in the lexical graph" | ||
| logger.info( | ||
| "No document metadata provided, " | ||
| "the document node won't be created in the lexical graph" |
Contributor
There was a problem hiding this comment.
I suggest something like
Document node not created in the lexical graph because no document metadata is provided
which is a bit more direct I think
willtai
approved these changes
Nov 25, 2024
willtai
pushed a commit
to willtai/neo4j-genai-python
that referenced
this pull request
Dec 9, 2024
…j#218) * Remove misleading warning * Update message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The behavior is "normal", hence no need to raise a warning.
Type of Change
Complexity
Complexity: Low
How Has This Been Tested?
Checklist
The following requirements should have been met (depending on the changes in the branch):