Improve Document/Chunk ID management #222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stellasia
commented
Dec 3, 2024
stellasia
commented
Dec 3, 2024
willtai
reviewed
Dec 3, 2024
willtai
reviewed
Dec 3, 2024
alexthomas93
reviewed
Dec 6, 2024
stellasia
force-pushed
the
fix/id-prefix
branch
from
e233382 to
1b724c5
Compare
stellasia
force-pushed
the
fix/id-prefix
branch
from
a68712a to
b4f59e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #221
Some explanations:
When running a pipeline (SimpleKGPipeline or not) over the same document multiple times, the relationships between chunks were messed up because we were recreating chunk nodes but using the same chunk ID.
What this PR does, is stop trying to build a unique ID from the chunk index, and add a unique ID to DocumentInfo and TextChunk model instead, so the unique ID are always there and truly unique.
Type of Change
Complexity
Complexity: High
How Has This Been Tested?
Checklist
The following requirements should have been met (depending on the changes in the branch):