Merged
Conversation
stellasia
commented
Dec 11, 2024
| raise ImportError( | ||
| "Could not import cohere python client. " | ||
| "Please install it with `pip install cohere`." | ||
| 'Please install it with `pip install "neo4j-graphrag[cohere]"`.' |
Contributor
Author
There was a problem hiding this comment.
I find it very confusing to have double quotes on the first line and single quotes on the second one, but that's a ruff thing, it seems to prefer double quotes whenever it's possible (and it's not possible on the second line because we have to use double quote for shell commands (well, I think?))
Contributor
There was a problem hiding this comment.
Will a multiline string work? e.g.
"""Could not import cohere python client.
Please install it with `pip install "neo4j-graphrag[cohere]"`."""
willtai
approved these changes
Dec 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Complexity
Complexity: Low
How Has This Been Tested?
Checklist
The following requirements should have been met (depending on the changes in the branch):