feat: Add support for Markdown files #496
Merged
ali-sedaghatbaf merged 37 commits intomainfrom Mar 27, 2026
Merged
Conversation
jonnylaw
reviewed
Mar 25, 2026
jonnylaw
reviewed
Mar 25, 2026
jonnylaw
reviewed
Mar 25, 2026
jonnylaw
reviewed
Mar 25, 2026
src/neo4j_graphrag/experimental/pipeline/config/template_pipeline/simple_kg_builder.py
Show resolved
Hide resolved
jonnylaw
reviewed
Mar 25, 2026
jonnylaw
reviewed
Mar 25, 2026
jonnylaw
reviewed
Mar 25, 2026
jonnylaw
reviewed
Mar 25, 2026
jonnylaw
approved these changes
Mar 25, 2026
Contributor
jonnylaw
left a comment
There was a problem hiding this comment.
Good stuff 🚀
A few missing tests and the MarkdownLoader currently returns PdfLoaderError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a major refactor and improvement to the document loading system in the experimental SimpleKG pipeline, expanding support for Markdown files and standardizing terminology and interfaces across the codebase and documentation. The changes include replacing the legacy
from_pdfandpdf_loaderparameters with the more generalfrom_fileandfile_loader, updating documentation and examples accordingly, and adding support for Markdown input. Backwards compatibility is preserved with deprecation warnings for old parameter names..md,.markdown) files in addition to PDFs when using the defaultFileLoader(CHANGELOG.md).from_pdfandpdf_loaderare replaced byfrom_fileandfile_loaderthroughout the codebase, configuration files, and documentation. Legacy names are still accepted with a deprecation warning (user_guide_kg_builder.rst,README.md, multiple example scripts and config files).PdfLoaderand related classes are moved frompdf_loaderto the newdata_loadermodule, which also introducesMarkdownLoaderand a unifiedFileLoader. All relevant imports and documentation are updated (api.rst, example scripts).LoadedDocumenttype replacesPdfDocumentas the standard output for data loaders, and documentation is updated to reflect this (types.rst, example scripts).UnsupportedDocumentFormatError, is introduced for unsupported file types in the document loader (exceptions.py).Type of Change
Complexity
Complexity: low
How Has This Been Tested?
Checklist
The following requirements should have been met (depending on the changes in the branch):