Skip to content

fix: Add default name property to node types defined without a properties key #499

Merged
ali-sedaghatbaf merged 4 commits intomainfrom
name-prop
Mar 31, 2026
Merged

fix: Add default name property to node types defined without a properties key #499
ali-sedaghatbaf merged 4 commits intomainfrom
name-prop

Conversation

@ali-sedaghatbaf
Copy link
Copy Markdown
Contributor

@ali-sedaghatbaf ali-sedaghatbaf commented Mar 30, 2026

Description

This pull request addresses a validation issue with node type definitions in the schema component. The main improvement is that node types defined without a properties key now automatically receive a default name: STRING property and additional_properties=True, preventing validation errors and matching the behavior for string input. Explicit settings for properties or additional_properties are still respected.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Documentation update
  • Project configuration change

Complexity

Complexity: low

How Has This Been Tested?

  • Unit tests
  • E2E tests
  • Manual tests

Checklist

The following requirements should have been met (depending on the changes in the branch):

  • Documentation has been updated
  • Unit tests have been updated
  • E2E tests have been updated
  • Examples have been updated
  • New files have copyright header
  • CLA (https://neo4j.com/developer/cla/) has been signed
  • CHANGELOG.md updated if appropriate

@ali-sedaghatbaf ali-sedaghatbaf requested a review from a team as a code owner March 30, 2026 11:34
@ali-sedaghatbaf ali-sedaghatbaf changed the title fix: Add default name| property node types defined without a properties key fix: Add default name property node types defined without a properties key Mar 30, 2026
@ali-sedaghatbaf ali-sedaghatbaf changed the title fix: Add default name property node types defined without a properties key fix: Add default name property to node types defined without a properties key Mar 30, 2026
Copy link
Copy Markdown
Contributor

@NathalieCharbel NathalieCharbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@ali-sedaghatbaf ali-sedaghatbaf merged commit 4582599 into main Mar 31, 2026
14 checks passed
@ali-sedaghatbaf ali-sedaghatbaf deleted the name-prop branch March 31, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants