Merged
Conversation
ali-sedaghatbaf
changed the title
stellasia
approved these changes
Mar 31, 2026
AmirLayegh
approved these changes
Mar 31, 2026
ali-sedaghatbaf
added a commit
that referenced
this pull request
Mar 31, 2026
This reverts commit 07df667.
ali-sedaghatbaf
added a commit
that referenced
this pull request
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes an issue with the
VertexAILLMintegration where passing a Pydantic model withextra="forbid"as theresponse_formatwould previously cause aParseError. The fix involves stripping unsupported JSON Schema fields (such asadditionalProperties) before forwarding the schema to VertexAI's protobufSchematype. Additionally, a utility function was introduced to recursively remove unsupported fields from the schema.Type of Change
Complexity
Complexity: low
How Has This Been Tested?
Checklist
The following requirements should have been met (depending on the changes in the branch):