Add default info for fetchSize session config#1071
Open
stefano-ottolenghi wants to merge 1 commit intoneo4j:5.0from
Open
Add default info for fetchSize session config#1071stefano-ottolenghi wants to merge 1 commit intoneo4j:5.0from
fetchSize session config#1071stefano-ottolenghi wants to merge 1 commit intoneo4j:5.0from
Conversation
bigmontz
approved these changes
Mar 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current undefined is a bit misleading, as it doesn't give away what the actual value is. I would then assume that no value => fetch all. I'd even advocate for putting 1000 into the docstring there, but this is a decision for @bigmontz