feat: Add batch support to Statement implementation#1296
Merged
michael-simons merged 2 commits intomainfrom Mar 11, 2026
Merged
feat: Add batch support to Statement implementation#1296michael-simons merged 2 commits intomainfrom
Statement implementation#1296michael-simons merged 2 commits intomainfrom
Conversation
Implement `addBatch(String)`, `clearBatch()`, and `executeBatch()` for `StatementImpl`, bringing plain `Statement` in line with the JDBC spec. Individual statements in the batch are executed via `executeUpdate0` with SQL processing enabled, supporting both Cypher and SQL. Failures throw `BatchUpdateException` with partial results per the JDBC contract. Also guard against executing individual statements while a batch is pending, requiring the batch to be executed or cleared first. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The unit tests in `StatementImplTests` expected `addBatch`, `clearBatch`, and `executeBatch` to throw `SQLFeatureNotSupportedException`, which is no longer correct after implementing batch support. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
meistermeier
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
addBatch(String),clearBatch(), andexecuteBatch()onStatementImpl, replacing the previousSQLFeatureNotSupportedExceptionstubsexecuteUpdate0with SQL processing enabled, supporting both Cypher and SQL statementsBatchUpdateExceptionwith partial results per the JDBC specificationexecuteQuery,executeUpdate,execute) when a batch is pending, requiring the batch to be executed or cleared firstTest plan
shouldExecuteBatchWithCypher— multiple Cypher CREATE statements, verify node countsshouldExecuteBatchWithSQL— SQL INSERT statements with translation enabledshouldClearBatch— verifyclearBatch()resets,executeBatch()returns empty arrayshouldThrowOnAddBatchWhenClosed— closed statement throwsSQLExceptionshouldThrowOnAddBatchWithNullSQL— null SQL throwsSQLExceptionshouldExecuteEmptyBatch— empty batch returns emptyint[]shouldRejectExecuteQueryWhenBatchPending—executeQueryblocked by pending batchshouldRejectExecuteUpdateWhenBatchPending—executeUpdateblocked by pending batchshouldRejectExecuteWhenBatchPending—executeblocked by pending batchshouldAllowExecuteAfterClearBatch— normal execution works after clearingshouldAllowExecuteAfterExecuteBatch— normal execution works after batch execution🤖 Generated with Claude Code