Skip to content

Fix remapping of mods using Archloom to package JIJ dependencies #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Matyrobbrt merged 1 commit into from
Dec 5, 2024
Merged

Fix remapping of mods using Archloom to package JIJ dependencies #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions legacytest/forge/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,6 @@ dependencies {
}
modRuntimeOnly('curse.maven:mekanism-268560:5662583')
modImplementation('curse.maven:applied-energistics-2-223794:5641282')
// This is an example for a mod that does NOT work with FG or MDG since its JiJ dependencies are
// packages into /META-INF/jars while installertools will only remap /META-INF/jarjar/*.jar
// modImplementation('curse.maven:gregtechceu-modern-890405:5641637')
}

neoForge {
Expand Down
2 changes: 1 addition & 1 deletion src/legacy/java/net/neoforged/moddevgradle/legacyforge/internal/LegacyForgeModDevPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public void apply(Project project) {
spec.setCanBeConsumed(false);
spec.setCanBeResolved(true);
spec.setTransitive(false);
spec.getDependencies().add(depFactory.create("net.neoforged.installertools:installertools:2.1.7:fatjar"));
spec.getDependencies().add(depFactory.create("net.neoforged.installertools:installertools:2.1.10:fatjar"));
});

// We use this directory to store intermediate files used during moddev
Expand Down
Loading