Skip to content

Remove superseded NeoDevFacade methods #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shartte merged 1 commit into from
Oct 10, 2025
Merged

Remove superseded NeoDevFacade methods #296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 0 additions & 44 deletions src/main/java/net/neoforged/moddevgradle/internal/NeoDevFacade.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,26 +24,6 @@
public final class NeoDevFacade {
private NeoDevFacade() {}

public static void setupRuns(Project project,
Provider<Directory> argFileDir,
DomainObjectCollection<RunModel> runs,
Object runTemplatesSourceFile,
Consumer<Configuration> configureModulePath,
Consumer<Configuration> configureAdditionalClasspath,
Provider<RegularFile> assetPropertiesFile) {
ModDevRunWorkflow.setupRuns(
project,
Branding.NEODEV,
argFileDir,
runs,
runTemplatesSourceFile,
configureModulePath,
configureAdditionalClasspath,
assetPropertiesFile,
// This overload of the method was only used by NeoForge 1.21.3
VersionCapabilitiesInternal.ofMinecraftVersion("1.21.3"));
}

public static void setupRuns(Project project,
Provider<Directory> argFileDir,
DomainObjectCollection<RunModel> runs,
Expand All @@ -64,30 +44,6 @@ public static void setupRuns(Project project,
neoFormVersion.map(VersionCapabilitiesInternal::ofNeoFormVersion).getOrElse(VersionCapabilitiesInternal.latest()));
}

public static void setupTestTask(Project project,
Provider<Directory> argFileDir,
TaskProvider<Test> testTask,
Object runTemplatesSourceFile,
Provider<Set<ModModel>> loadedMods,
Provider<ModModel> testedMod,
Consumer<Configuration> configureModulePath,
Consumer<Configuration> configureAdditionalClasspath,
Provider<RegularFile> assetPropertiesFile) {
ModDevRunWorkflow.setupTestTask(
project,
Branding.NEODEV,
runTemplatesSourceFile,
testTask,
loadedMods,
testedMod,
argFileDir,
configureModulePath,
configureAdditionalClasspath,
assetPropertiesFile,
// This overload of the method was only used by NeoForge before 1.21.9
VersionCapabilitiesInternal.ofMinecraftVersion("1.21.8"));
}

public static void setupTestTask(Project project,
Provider<Directory> argFileDir,
TaskProvider<Test> testTask,
Expand Down
Loading