Skip to content

[hotfix] Removed Lerp / InverseLerp internal methods. #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025
Merged

[hotfix] Removed Lerp / InverseLerp internal methods. #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions RhythmGameUtilities/Scripts/Common.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ public static class CommonInternal
{

[DllImport("libRhythmGameUtilities", CallingConvention = CallingConvention.Cdecl)]
public static extern float LerpInternal(float a, float b, float t);
public static extern float Lerp(float a, float b, float t);

[DllImport("libRhythmGameUtilities", CallingConvention = CallingConvention.Cdecl)]
public static extern float InverseLerpInternal(float a, float b, float v);
public static extern float InverseLerp(float a, float b, float v);

}

Expand All @@ -25,7 +25,7 @@ public static class Common
/// <param name="t">The value used for interpolation.</param>
public static float Lerp(float a, float b, float t)
{
return CommonInternal.LerpInternal(a, b, t);
return CommonInternal.Lerp(a, b, t);
}

/// <summary>
Expand All @@ -36,7 +36,7 @@ public static float Lerp(float a, float b, float t)
/// <param name="v">The value in the middle.</param>
public static float InverseLerp(float a, float b, float v)
{
return CommonInternal.InverseLerpInternal(a, b, v);
return CommonInternal.InverseLerp(a, b, v);
}

}
Expand Down
8 changes: 4 additions & 4 deletions UnityPackage/Scripts/Common.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ public static class CommonInternal
{

[DllImport("libRhythmGameUtilities", CallingConvention = CallingConvention.Cdecl)]
public static extern float LerpInternal(float a, float b, float t);
public static extern float Lerp(float a, float b, float t);

[DllImport("libRhythmGameUtilities", CallingConvention = CallingConvention.Cdecl)]
public static extern float InverseLerpInternal(float a, float b, float v);
public static extern float InverseLerp(float a, float b, float v);

}

Expand All @@ -25,7 +25,7 @@ public static class Common
/// <param name="t">The value used for interpolation.</param>
public static float Lerp(float a, float b, float t)
{
return CommonInternal.LerpInternal(a, b, t);
return CommonInternal.Lerp(a, b, t);
}

/// <summary>
Expand All @@ -36,7 +36,7 @@ public static float Lerp(float a, float b, float t)
/// <param name="v">The value in the middle.</param>
public static float InverseLerp(float a, float b, float v)
{
return CommonInternal.InverseLerpInternal(a, b, v);
return CommonInternal.InverseLerp(a, b, v);
}

}
Expand Down
27 changes: 0 additions & 27 deletions include/RhythmGameUtilities/CommonInternal.hpp
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion include/RhythmGameUtilities/RhythmGameUtilities.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

#include "Audio.hpp"
#include "Common.hpp"
#include "CommonInternal.hpp"
#include "Parsers.hpp"
#include "ParsersInternal.hpp"
#include "Utilities.hpp"
Expand Down
34 changes: 0 additions & 34 deletions tests/RhythmGameUtilities/CommonInternal.cpp
View file
Open in desktop

This file was deleted.