Also allow unnecessary_fallible_conversions lint #6294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bayandin
added
the
run-extra-build-macos
conradludgate
approved these changes
Jan 8, 2024
2238 tests run: 2155 passed, 0 failed, 83 skipped (full report)Code coverage (full report)
The comment gets automatically updated with the latest test results
cd44433 at 2024-01-09T02:11:53.970Z :recycle: |
|
@arpad-m could you please rebase the branch to trigger a workflow on macOS (rerunning job doesn't pick up new labels) |
arpad-m
force-pushed
the
arpad/fix_macos_clippy
branch
from
411b79b to
cd44433
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the clippy lint firing on macOS on the conversion which needed for portability. For some reason, the logic in rust-lang/rust-clippy#11669 to avoid an overlap is not working.