Proposed solution for db_url output issues#14
Open
danielrose7 wants to merge 1 commit intoneondatabase:mainfrom
Open
Proposed solution for db_url output issues#14danielrose7 wants to merge 1 commit intoneondatabase:mainfrom
danielrose7 wants to merge 1 commit intoneondatabase:mainfrom
Conversation
danielrose7
changed the title
|
Very dangerous... can we merge it asap? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe that there is an issue getting the branch_id as the action is outputting the default connection string rather than the connection string for the branch that was just reset to its parent
See issue #13
Using the branch name from the input seems to suffice
I'm unsure what other change(s) should go into this like a version bump