Skip to content

DRAFT: Raise PhpStan to level 8 - Part 2 #3518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 32 commits into
base: 9.1
Choose a base branch
from
Draft

DRAFT: Raise PhpStan to level 8 - Part 2 #3518

wants to merge 32 commits into from

Conversation

@mficzel
Copy link
Member

@mficzel mficzel commented Oct 27, 2025 •
edited
Loading

Raise PhpStan to level 8 for:

  • Neos.Flow/Classes/Security
  • Neos.Flow/Classes/Session
  • Neos.Flow/Classes/SignalSlot
  • Neos.Flow/Classes/Utility
  • Neos.Flow/Validation

This is a follow up for: #3515

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

Bernhard Schmitt and others added 26 commits October 27, 2025 16:06
@mficzel
WIP: Adjust Neos.Utility.Unicode
aba08c1
@mficzel
Adjust Neos.Utility.Schema
851da67
@mficzel
Adjust Neos.Utility.Pdo
4e16d8f
@mficzel
Adjust Neos.Utility.ObjectHandling
e9241bc
@mficzel
Adjust Neos.Utility.MediaTypes
cd3cadc
@mficzel
Adjust Neos.Utility.Files
7728d8d
@mficzel
Adjust Neos.Utility.Arrays
85b57a2
@mficzel
TASK: Revert breaking changes to Utility->ObjectAccess
6d0fd1f
@mficzel
TASK: Revert breaking changes to Utility->Arrays
686ad05
@mficzel
TASK: Revert breaking changes of Utility.MediaTypes
3007bea
@mficzel
TASK: Adjust phpstan config to apply level 8 rules to the utility pac…
e76dde5 
…kages and use level 3 otherwise
@mficzel
TASK: Adjust utility packages to phpstan level 8
b5eb922
@mficzel
Adjust Neos.Kickstarter
07d75d6
@mficzel
Adjust Neos.Http.Factories
b58dc60
@mficzel
Adjust Neos.Http.Factories
151671f
@mficzel
Adjust Neos.Http.Factories to Neos.Flow Http subcontext adjustments
e303bc4
@mficzel
add scanDirectories folders for special classes
f98e014
@mficzel
TASK: Adjust Http.Factories and Kickstarter for Stan level 8
baa09ad
@mficzel
Adjust Neos.FluidAdaptor
41b9a94
@mficzel
TASK: Adjust FluidAdapter for PhpStan level 8
f0ee451
@mficzel
Adjust Neos.Flow.Log
f6d38e7
@mficzel
TASK: Raise PhpStan level for Flow.Log to 8 and adjust breakiness
5e02f0c
@mficzel
Adjust Neos.Flow Validation subcontext
25d723e
@mficzel
Adjust Neos.Flow Utility subcontext
f732a66
@mficzel
Adjust Neos.Flow SignalSlot subcontext
f8f35a7
@mficzel
Remove erroneous class check
6330bb6
@github-actions github-actions bot added the 9.1 label Oct 27, 2025
@mficzel mficzel changed the base branch from 9.1 to phpstanLevel8-v3 October 27, 2025 16:05
@mficzel mficzel force-pushed the phpstanLevel8-v3-part2 branch from 4c9f1b0 to ed984c0 Compare November 7, 2025 13:52
@mficzel mficzel force-pushed the phpstanLevel8-v3-part2 branch from e4a16fd to d8b7541 Compare November 7, 2025 14:25
@mficzel mficzel changed the base branch from phpstanLevel8-v3 to 9.1 November 7, 2025 14:28
@mficzel mficzel closed this Nov 7, 2025
@mficzel mficzel reopened this Nov 7, 2025
@mficzel mficzel force-pushed the phpstanLevel8-v3-part2 branch 4 times, most recently from 8e64e0c to 519e646 Compare November 7, 2025 16:01
@mficzel mficzel force-pushed the phpstanLevel8-v3-part2 branch 2 times, most recently from 5c4fc36 to f485bc7 Compare November 7, 2025 16:16
@mficzel
TASK: Adjust phpstan config to apply level 8 rules to the Flow/Securi…
e185eb9 
…ty context and remove breaking changes

Some return type Annotations in the ObjectManagerInterface are adjusted to match the reality already to prevent false errors beeing reported by PhpStan
@mficzel mficzel force-pushed the phpstanLevel8-v3-part2 branch 7 times, most recently from 569883c to f422f3c Compare November 7, 2025 18:25
@mficzel mficzel closed this Nov 7, 2025
@mficzel mficzel force-pushed the phpstanLevel8-v3-part2 branch from f422f3c to 587ecda Compare November 7, 2025 18:41
@mficzel mficzel reopened this Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

9.1 phpstanLevel8-v3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mficzel