BUGFIX: Pass through enum mapping to ORM #3533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows to use the enumType property for a `Column` attribute and thus use enums as types in entities with the mapping being handled by doctrine ORM. The special case for the "type" is no longer needed as it has been nullable in the attribute/annotation for some years now, so we can rely on a default null if you didn't configure the type, and therefore triggering our auto detection in this case. We need this special case removed to allow string backed enums to be mapped correctly, as we need to fix the type to string and bypass auto detection.
Member
Author
|
Probably should add a behat test with an enum in an entity |
kdambekalns
approved these changes
Jan 21, 2026
Member
Author
|
Well behat in Flow still needs a major refactoring so functional test it is... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows to use the enumType property for a
Columnattribute and thus use enums as types in entities with the mapping being handled by doctrine ORM. The special case for the "type" is no longer needed as it has been nullable in the attribute/annotation for some years now, so we can rely on a default null if you didn't configure the type, and therefore triggering our auto detection in this case. We need this special case removed to allow string backed enums to be mapped correctly, as we need to fix the type to string and bypass auto detection.In 8.3 we could remove the special handling for type already, but enumType was not available in the lowest accepted ORM version, therefore I targeted 8.4 as the required ORM version contains enumType.