BUGFIX: Ensure Node->timestamps use UTC format consistently and not date_default_timezone_get() base on the system
#5716
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `date_default_timezone_get()` base on the system In the database we dont persist the timezone but only the date. And dbal seems to automatically store them in UTC which makes sense. During deserializing we need to ensure that we use always `UTC` too and never ask the system for its fallback as this is irrelevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the database we dont persist the timezone but only the date. And dbal seems to automatically store them in UTC which makes sense.
During deserializing we need to ensure that we use always
UTCtoo and never ask the system for its fallback as this is irrelevant.Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions