WIP Neos 10 TASK: Remove legacy neos.configuration b/c layer
#4029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion.allowedTargetWorkspaces` and `frontendConfigurationRegistry.get('editPreviewModes')`"
This reverts commit 5505f1b.
… injected via `neos.configuration` when using `@neos()` This is not expected to break any plugin as its highly advanced to fetch configuration like this and there was unlikely need to fetch the nodeTree loading depth. -> The archeopteryx which needed this info would infact get it via the plugin bootstrap and this continues to work.
mhsdesign
force-pushed
the
task/remove-legacy-neos-configuration-bc-layer
branch
from
38ba8f8 to
d3b6c20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Either merged into a minor or 10 but yes
Followup to #4012
frontendConfigurationno longer carries theeditPreviewModessetting{configuration}as parameter@neos()decoratorneos.configurationis no longer availableconfiguration.allowedTargetWorkspacesis no longer stored as configuration but in the redux store viaselectors.CR.Workspaces.allowedTargetWorkspacesSelector()What I did
How I did it
How to verify it