build: infer prettier parser from file extension #435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, mind rebasing? |
Issue ===== The prettier parser was set to `typescript` in the `.prettierrc.json` file. Because prettier was used for multiple files types, it caused errors when formatting files that were not TypeScript. Here is an example: ```sh README.md [error] README.md: SyntaxError: Invalid character. (1:1) [error] > 1 | # Neovim node.js client [error] | ^ [error] 2 | [error] 3 | | CI (node >= 14, Linux/macOS/Windows) | Coverage | npm | [error] 4 | |----------------------------|----------|-----| ``` This seems to cause the build to fail as of the most recent commit neovim@7488014 Solution ======== Automatically infer the parser based on the file extension. References: - https://prettier.io/docs/en/configuration.html#setting-the-parserdocsenoptionshtmlparser-option To make the build pass, run `npx prettier --write .` to format all files. I think it's best that someone else does this, as it will change the formatting of many files (currently 43), and reviewing them is very difficult.
mikavilpas
force-pushed
the
fix-prettier-parser
branch
from
9a74ac7 to
74a6632
Compare
npx prettier --write .
|
Just rebased to master - I kept the new I also ran |
justinmk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The prettier parser was set to
typescriptin the.prettierrc.jsonfile. Because prettier was used for multiple files types, it caused errors when formatting files that were not TypeScript.Here is an example:
This seems to cause the build to fail as of the most recent commit 7488014
Solution
Automatically infer the parser based on the file extension.
References:
To make the build pass, run
npx prettier --write .to format all files. I think it's best that someone else does this, as it will change the formatting of many files (currently 43), and reviewing them is very difficult.