deps: update eslint, migrate to "flat" config, drop eslint-config-airbnb #490
+2,822
−2,228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps the eslint group with 6 updates: | Package | From | To | | --- | --- | --- | | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) | `6.20.0` | `8.41.0` | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) | `6.20.0` | `8.41.0` | | [eslint](https://github.com/eslint/eslint) | `8.56.0` | `8.57.1` | | [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) | `9.1.0` | `10.1.8` | | [eslint-plugin-import](https://github.com/import-js/eslint-plugin-import) | `2.29.1` | `2.32.0` | | [eslint-plugin-unicorn](https://github.com/sindresorhus/eslint-plugin-unicorn) | `50.0.1` | `60.0.0` | Updates `@typescript-eslint/eslint-plugin` from 6.20.0 to 8.41.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.41.0/packages/eslint-plugin) Updates `@typescript-eslint/parser` from 6.20.0 to 8.41.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.41.0/packages/parser) Updates `eslint` from 8.56.0 to 8.57.1 - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.56.0...v8.57.1) Updates `eslint-config-prettier` from 9.1.0 to 10.1.8 - [Release notes](https://github.com/prettier/eslint-config-prettier/releases) - [Changelog](https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md) - [Commits](prettier/eslint-config-prettier@v9.1.0...v10.1.8) Updates `eslint-plugin-import` from 2.29.1 to 2.32.0 - [Release notes](https://github.com/import-js/eslint-plugin-import/releases) - [Changelog](https://github.com/import-js/eslint-plugin-import/blob/main/CHANGELOG.md) - [Commits](import-js/eslint-plugin-import@v2.29.1...v2.32.0) Updates `eslint-plugin-unicorn` from 50.0.1 to 60.0.0 - [Release notes](https://github.com/sindresorhus/eslint-plugin-unicorn/releases) - [Commits](sindresorhus/eslint-plugin-unicorn@v50.0.1...v60.0.0) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-version: 8.41.0 dependency-type: direct:development update-type: version-update:semver-major dependency-group: eslint - dependency-name: "@typescript-eslint/parser" dependency-version: 8.41.0 dependency-type: direct:development update-type: version-update:semver-major dependency-group: eslint - dependency-name: eslint dependency-version: 8.57.1 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: eslint - dependency-name: eslint-config-prettier dependency-version: 10.1.8 dependency-type: direct:development update-type: version-update:semver-major dependency-group: eslint - dependency-name: eslint-plugin-import dependency-version: 2.32.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: eslint - dependency-name: eslint-plugin-unicorn dependency-version: 60.0.0 dependency-type: direct:development update-type: version-update:semver-major dependency-group: eslint ... Signed-off-by: dependabot[bot] <[email protected]>
need to do this before removing airbnb
Problem: `[email protected]` doesn't support ESLint 9 (only ^7.32.0 || ^8.2.0). Airbnb is working on ESLint 9 support, but no compatible version exists yet. Solution: Just remove the airbnb rules. They were never very good, and we added unicorn since then.
justinmk
changed the title
remove airbnb, update eslint
Problem:
$ eslint --format=unix .
The unix formatter is no longer part of core ESLint. Install it
manually with `npm install -D eslint-formatter-unix`
Solution:
Install `eslint-formatter-unix`.
Problem:
[email protected] lint
> prettier --check . && eslint --format=unix --ignore-pattern 'packages/example*/**' --ignore-pattern 'packages/neovim/lib/**/*.js' .
ESLint: 9.34.0
TypeError: object.split(...).toReversed is not a function
at createTraceMap (file:///D:/a/node-client/node-client/node_modules/eslint-plugin-unicorn/rules/utils/global-reference-tracker.js:6:33)
at new GlobalReferenceTracker (file:///D:/a/node-client/node-client/node_modules/eslint-plugin-unicorn/rules/utils/global-reference-tracker.js:27:34)
at file:///D:/a/node-client/node-client/node_modules/eslint-plugin-unicorn/rules/no-document-cookie.js:8:17
at ModuleJob.run (node:internal/modules/esm/module_job:195:25)
Solution:
Only run lint task on latest nodejs
Problem: eslint has lost its mind and makes it very difficult to lint some .js files but not others. Solution: ignore all .js files for now. TODO: output webpack'd js files to a dist/ directory so that we can lint non-generated .js files...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #485