Skip to content

Conversation

seejaysea-dev
Copy link
Contributor

@seejaysea-dev seejaysea-dev commented Jun 20, 2025

Problem:
Powershell Editor Services does not recognize -LogLevel Information and this prevents the LSP from starting

Solution:
Revert update to command_fmt to use a recognized log level from Start-EditorServices.ps1

@seejaysea-dev
Copy link
Contributor Author

fixes bug #3918

@sharpchen
Copy link
Contributor

I think we should revert #3914

@seejaysea-dev
Copy link
Contributor Author

Ah, I didn't see that PR

@seejaysea-dev seejaysea-dev force-pushed the fix_poweshell_es_loglevel branch from c993b26 to e7cabb5 Compare June 21, 2025 01:03
@seejaysea-dev
Copy link
Contributor Author

Updated to revert commit

@justinmk
Copy link
Member

#3914 notes that Normal was removed in PowerShell/PowerShellEditorServices@d9de5bd , do we need to decide this based on the LS version ?

@justinmk justinmk merged commit 89cc7b6 into neovim:master Jun 21, 2025
6 checks passed
@sharpchen
Copy link
Contributor

@justinmk The issue is the wrapper script Start-EditorServices.ps1 has an outdated validation that doesn't allow new log levels, which caused the error. Normal will be deprecated in the future but currently still available, so we don't have to decide on ls version, once the pwsh_es updated the log level validation we can change it to Information again.

https://github.com/PowerShell/PowerShellEditorServices/blob/3a429eac5544fd7613c281c0814f94ac03fad551/module/PowerShellEditorServices/Start-EditorServices.ps1#L49

@eitamal
Copy link

eitamal commented Jun 22, 2025

I've opened with PowerShell/PowerShellEditorServices:

So, hopefully it'll be fixed soon :)

Maybe worth noting, they've added some conversion code for backwards compatibility: StartEditorServicesCommand.cs which covers Normal -> Information - so there shouldn't be any urgency in getting the change back to Information out (in case there was any).

@seejaysea-dev
Copy link
Contributor Author

Thanks @eitamal. I was hoping to get the time to do almost this exact PR today in PES

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants