Merged
Conversation
Contributor
MaciekPytel
commented
Feb 11, 2025
MaciekPytel
commented
- Pin version of api-generator to make generated files consistent between different dev environments.
- Run pre-commit hook to re-add license as part of the script. Without that the script generates massive noise and it is very hard to guess that you need to commit all those unwanted changes in order to get rid of them.
MaciekPytel
requested review from
PatrykGala,
kgodlewski and
michalsosn
as code owners
PatrykGala
reviewed
Feb 14, 2025
scripts/update.sh
Outdated
| git checkout HEAD -- $entry | ||
| done | ||
|
|
||
| pre-commit run insert-license --all-files |
Contributor
There was a problem hiding this comment.
Suggested change
| pre-commit run insert-license --all-files | |
| pre-commit run --all-files |
PatrykGala
approved these changes
Feb 14, 2025
* Pin version of api-generator to make generated files consistent between different dev environments. * Run pre-commit hook to re-add license as part of the script. Without that the script generates massive noise and it is very hard to guess that you need to commit all those unwanted changes in order to get rid of them.
MaciekPytel
force-pushed
the
fix-generation
branch
from
68efa50 to
54cb759
Compare
PatrykGala
approved these changes
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.