Merged
Conversation
gabrys
reviewed
Aug 21, 2025
| "define it in the module using `NEPTUNE_PROJECT = 'your_project_name'`." | ||
| ) | ||
| raise RuntimeError("NEPTUNE_E2E_PROJECT environment variable is not set") | ||
| return Project(project_identifier=project_identifier) |
Contributor
There was a problem hiding this comment.
Might be not worth it, but I believe of the Project class, we only ever use the "project_identifier" across the tests, so maybe just return string (and return the fixture)
Member
Author
There was a problem hiding this comment.
Not sure. Type safety (such as it is) is rarely a bad thing. If we wanted to add something else there, refactoring back to what we have now will be a pain (I tried changing this with copilot just now - not pleasant).
gabrys
reviewed
Aug 21, 2025
Contributor
gabrys
left a comment
gabrys
left a comment
There was a problem hiding this comment.
Mostly looks good, will take a closer look tomorrow
gabrys
approved these changes
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.