Conversation
…onnectivity_test before e2e tests
pitercl
requested changes
Jan 12, 2026
tests/e2e/data_ingestion.py
Outdated
Comment on lines
260
to
275
| for run_id in run_ids: | ||
| sys_ids_by_run_id = fetch_sys_ids(attribute_name="sys/custom_run_id", attribute_value=run_id) | ||
| if len(sys_ids_by_run_id) > 1: | ||
| raise RuntimeError(f"Expected exactly one sys_id for run_id {run_id}, got {sys_ids_by_run_id}") | ||
| if len(sys_ids_by_run_id) == 1: | ||
| found_runs += 1 | ||
|
|
||
| for experiment_name in experiment_names: | ||
| sys_ids_by_experiment_name = fetch_sys_ids(attribute_name="sys/name", attribute_value=experiment_name) | ||
| if len(sys_ids_by_experiment_name) > 1: | ||
| raise RuntimeError( | ||
| f"Expected exactly one sys_id for experiment_name {experiment_name}, " | ||
| f"got {sys_ids_by_experiment_name}" | ||
| ) | ||
| if len(sys_ids_by_experiment_name) == 1: | ||
| found_experiments += 1 |
Member
There was a problem hiding this comment.
This should be a single API call made with search.fetch_run_sys_attrs, without a filter. We don't need to check experiments separately.
gabrys
force-pushed
the
gabrys/e2e-wait-for-ingestion
branch
from
f338d3c to
2b46d56
Compare
pitercl
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting checklist