Optimize table fetches for explicit attribute lists via entries-search projection#210
Merged
PatrykGala merged 1 commit intomainfrom Feb 12, 2026
Merged
Conversation
PatrykGala
changed the title
PatrykGala
force-pushed
the
pg/optimize-fetch-runs-table
branch
from
4dd75ce to
d9d180b
Compare
maciejpyteloai
approved these changes
Feb 12, 2026
maciejpyteloai
left a comment
maciejpyteloai
left a comment
There was a problem hiding this comment.
Really good improvement. Left some minor comment, feel free to ignore if you disagree
| sort_by_inference_result.emit_warnings() | ||
|
|
||
| if exact_attribute_names is not None: | ||
| exact_attribute_names_set = set(exact_attribute_names) |
There was a problem hiding this comment.
nit: I would move this to a helper function
| ) | ||
| NEPTUNE_QUERY_ATTRIBUTE_VALUES_BATCH_SIZE = EnvVariable[int]("NEPTUNE_QUERY_ATTRIBUTE_VALUES_BATCH_SIZE", int, 10_000) | ||
| NEPTUNE_QUERY_ENTRIES_SEARCH_MAX_PROJECTION_ATTRIBUTES = EnvVariable[int]( | ||
| "NEPTUNE_QUERY_ENTRIES_SEARCH_MAX_PROJECTION_ATTRIBUTES", int, 1000 |
| ) | ||
|
|
||
|
|
||
| def test_fetch_experiments_table_uses_entries_search_fast_path_for_exact_attribute_list(): |
There was a problem hiding this comment.
Maybe consider a separate test where fast path returns non-empty result to test new formatting logic (e.g. that sys/id that is in projection is used for building identifier, but not included in values...).
MaciekPytel
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MR Summary