feat: merge 1st and 2nd bucket#44
Merged
michalsosn merged 3 commits intodev/fetch-metric-bucketsfrom Sep 5, 2025
Merged
Conversation
michalsosn
force-pushed
the
ms/buckets-merge
branch
from
0376404 to
2e61739
Compare
gabrys
reviewed
Sep 5, 2025
pitercl
approved these changes
Sep 5, 2025
Comment on lines
+497
to
+498
| 1st returned bucket is always (-inf, first_point], which we merge with the 2nd bucket (first_point, end], | ||
| resulting in a new bucket [first_point, end]. |
Member
There was a problem hiding this comment.
That's not true for single point series, according to what you wrote earlier.
For single point series we get [first_point, inf)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 9, 2025
* feat: fetch_metrics_buckets output format + draft of the rest (#25) * feat: fetch_metrics_buckets [WIP] * fix: naming * fix: use IntervalIndex for buckets * fix: review --------- Co-authored-by: Michał Sośnicki <michal.sosnicki@neptune.ai> * feat: directly fetch run_attribute_definitions (#27) * wip * feat: directly fetch run_attribute_definitions * feat: apply fetch_run_attribute_definitions to fethc_metric_buckets * fix: revert changes to metrics * fix: add tests for fetch_run_attribute_definitions_single_filter * Deduplicate attribute values fetching logic (#30) * fix: review * fix: remove test --------- Co-authored-by: Michał Sośnicki <michal.sosnicki@neptune.ai> * fix: review --------- Co-authored-by: Michał Sośnicki <michal.sosnicki@neptune.ai> * PY-225 Retrieval code communicating to the backend for metric rendering API (#28) * Bump neptune-api to the dev version * PY-225 Retrieval code communicating to the backend for metric rendering API * Remove debugging left-overs * Code review notes addressed * Rename BucketMetric to TimeseriesBucket and populate all fields that backend sends * Fix protobuf_v4plus imports * Remove DEFAULT_MAX_BUCKETS and x_neptune_client_metadata * fix circular import * Fix unit tests too * chore: rename cols/index (#32) Co-authored-by: Michał Sośnicki <michal.sosnicki@neptune.ai> * feat: add logger (#33) * feat: add logger * Update src/neptune_query/internal/retrieval/retry.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/neptune_query/internal/retrieval/retry.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Michał Sośnicki <michal.sosnicki@neptune.ai> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix: sort create_metric_buckets_dataframe output df (#34) Co-authored-by: Michał Sośnicki <michal.sosnicki@neptune.ai> * fix: change column name (#35) * Bump neptune-api to 0.22.0 (#36) * PY-235 Fix deserialization of optional fields of ProtoTimeseriesBucketsDTO (#40) * PY-235 Fix deserialization of optional fields of ProtoTimeseriesBucketsDTO * Update dataclass types too * PY-233 Add @experimental decorator to fetch_metric_buckets (#42) * PY-233 Add @experimental decorator to fetch_metric_buckets * Add docstring for fetch_metric_buckets() (#37) * add docstrings for fetch_metric_buckets() * chore: add metric buckets tests (#31) * chore: add some bucket tests * fix: x range calcs * fix: add nan/inf tests * add different xs axes tests * fix --------- Co-authored-by: Michał Sośnicki <michal.sosnicki@neptune.ai> * feat: merge 1st and 2nd bucket (#44) * feat: merge 1st and 2nd bucket * fix: add several tests * fix: limit 1000 and range ends equality --------- Co-authored-by: Michał Sośnicki <michal.sosnicki@neptune.ai> * fix: add proper typing to experimental decorator (#51) * fix: take start_point in the first bucket of a series (#45) * take 1st point in the first series bucket * fix: return proper first/last x/y from generate_categorized_rows --------- Co-authored-by: Michał Sośnicki <michal.sosnicki@neptune.ai> * Fix output format for all non finite rows (#43) * PY-236 Fix output format for all non finite rows * fix: change index->filter in create_metrics_dataframe. Use ind/col instead of 0/1 * add a test with a bucket series of nans --------- Co-authored-by: Michał Sośnicki <michal.sosnicki@neptune.ai> * fix: experimental status of fetch_metric_buckets in docstrings (#52) * fix: experimental status of fetch_metric_buckets in docstrings * Copy the copy from docs * Some more changes --------- Co-authored-by: Michał Sośnicki <michal.sosnicki@neptune.ai> Co-authored-by: Piotr Gabryjeluk <piotr.gabryjeluk@neptune.ai> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Piotr Łusakowski <piotr.lusakowskI@neptune.ai> Co-authored-by: Sabine Ståhlberg <sabine.stahlberg@neptune.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.