-
Notifications
You must be signed in to change notification settings - Fork 2
PY-206 Improve retries UX in neptune-query #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gabrys
merged 7 commits into
main
from
gabrys/py-206-improve-retries-ux-in-neptune-query
Sep 15, 2025
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a2778a8
Make a warning class for the type inference warnings
gabrys 5ea4b57
Add mechanism for throttled warnings and use that for the Experimenta…
gabrys 99f2653
Add throttled warnings for retries
gabrys ffd3bc4
Updates to the warning throttling
gabrys fd3fe38
Remove unused debug-only function
gabrys 20d2b18
Update comments in `test_warnings.py`
gabrys e24f035
Format code
gabrys File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| # | ||
| # Copyright (c) 2025, Neptune Labs Sp. z o.o. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| import sys | ||
| import warnings | ||
| from datetime import ( | ||
| datetime, | ||
| timedelta, | ||
| ) | ||
| from typing import Type | ||
|
|
||
| from neptune_query.warnings import ( | ||
| ExperimentalWarning, | ||
| Http5xxWarning, | ||
| Http429Warning, | ||
| HttpOtherWarning, | ||
| ) | ||
|
|
||
| # registry of warnings that were already emitted with the (type, message) tuple | ||
| WARNING_TYPES_EMITTED_ONCE_PER_MESSAGE = (ExperimentalWarning,) | ||
|
|
||
| # registry of warning types that were already emitted with the time they should be silenced until | ||
| WARNING_TYPES_EMITTED_ONCE_PER_WHILE = (Http429Warning, Http5xxWarning, HttpOtherWarning) | ||
| WARNING_SUPPRESSION_DURATION = timedelta(seconds=20) | ||
|
|
||
| _silence_warnings_msg: set[tuple[Type[Warning], str]] = set() | ||
| _silence_warnings_until: dict[Type[Warning], datetime] = {} | ||
|
|
||
|
|
||
| def get_thread_id() -> int: | ||
| import threading | ||
|
|
||
| return threading.get_ident() % 123 | ||
|
|
||
|
|
||
| def format_warning(warning: Warning) -> Warning: | ||
| # check if stderr is a terminal: | ||
| if sys.stderr.isatty(): | ||
| orange_bold = "\033[1;38;2;255;165;0m" | ||
| end = "\033[0m" | ||
| msg = f"{orange_bold}{str(warning)}{end}" | ||
| return type(warning)(msg) | ||
| else: | ||
| return warning | ||
|
|
||
|
|
||
| def throttled_warn(warning: Warning, stacklevel: int = 3) -> None: | ||
| if isinstance(warning, WARNING_TYPES_EMITTED_ONCE_PER_MESSAGE): | ||
| key = (type(warning), str(warning)) | ||
| if key in _silence_warnings_msg: | ||
| return | ||
| _silence_warnings_msg.add(key) | ||
|
|
||
| if isinstance(warning, WARNING_TYPES_EMITTED_ONCE_PER_WHILE): | ||
| warning_type = type(warning) | ||
| now = datetime.now() | ||
| if warning_type in _silence_warnings_until and _silence_warnings_until[warning_type] > now: | ||
| return | ||
| _silence_warnings_until[warning_type] = now + WARNING_SUPPRESSION_DURATION | ||
|
|
||
| warnings.warn(format_warning(warning), stacklevel=stacklevel) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.