Fix retries for get_timeseries_buckets_proto.sync_detailed#58
Merged
Conversation
michalsosn
reviewed
Sep 12, 2025
| @@ -147,7 +166,7 @@ def fetch_time_series_buckets( | |||
| call_api = retry.handle_errors_default(with_neptune_client_metadata(get_timeseries_buckets_proto.sync_detailed)) | |||
Contributor
There was a problem hiding this comment.
hmm, I guess
call_api = retry.handle_errors_default(with_neptune_client_metadata(lambda : get_timeseries_buckets_proto.sync_detailed(client=client, body=File(payload=BytesIO(request_object.SerializeToString())))))
response = call_api()
should recreate BytesIO on each retry.
I assume File2 is more like a test of an idea given the name :p
This bug seems like sth that could return in the future, so a test would be nice
gabrys
force-pushed
the
gabrys/fix-retries-for-fetch-metric-buckets
branch
from
96fb95c to
79ed7f8
Compare
michalsosn
approved these changes
Sep 15, 2025
gabrys
force-pushed
the
gabrys/fix-retries-for-fetch-metric-buckets
branch
2 times, most recently
from
6499604 to
ae77d9f
Compare
gabrys
force-pushed
the
gabrys/fix-retries-for-fetch-metric-buckets
branch
from
ae77d9f to
9d6231e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting checklist