Merged
Conversation
gabrys
approved these changes
Aug 18, 2025
| push: | ||
| tags: | ||
| - "neptune_query/*" | ||
| - "*" |
Contributor
There was a problem hiding this comment.
I'm likely to forget we no longer want the neptune_query prefix, so I'd rather match "1.*" for now. WDYT?
Member
Author
There was a problem hiding this comment.
IMO if you want validation, let's check if it conforms to semver. Having 1.* match doesn't convey the intention.
Contributor
There was a problem hiding this comment.
I don't know how to match semver in here, but I want to prevent the one type of error I'm likely to make :-)
gabrys
force-pushed
the
pl/fetcher-cleanup
branch
from
84a171c to
d936894
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.