Skip to content

Conversation

@SiddhantSadangi
Copy link
Member

@SiddhantSadangi SiddhantSadangi commented Jul 25, 2025

What does this PR do?

Fixes #<issue_number>

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--3.org.readthedocs.build/en/3/

@SiddhantSadangi SiddhantSadangi self-assigned this Jul 25, 2025
@github-actions
Copy link

github-actions bot commented Jul 25, 2025

⛈️ Required checks status: Has failure 🔴

Warning
This job will need to be re-run to merge your PR. If you do not have write access to the repository, you can ask Lightning-AI/lai-frameworks to re-run it. If you push a new commit, all of CI will re-trigger.

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu-guardian success

These checks are required after the changes to src/lightning/pytorch/loggers/neptune.py.

🟡 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) (testing Lightning latest) no_status
pytorch-lightning (GPUs) (testing PyTorch latest) no_status

These checks are required after the changes to src/lightning/pytorch/loggers/neptune.py.

🟡 pytorch_lightning: Benchmarks
Check ID Status
lightning.Benchmarks no_status

These checks are required after the changes to src/lightning/pytorch/loggers/neptune.py.

🔴 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) failure
docs-make (pytorch, html) failure

These checks are required after the changes to src/lightning/pytorch/loggers/neptune.py.

🔴 mypy
Check ID Status
mypy failure

These checks are required after the changes to src/lightning/pytorch/loggers/neptune.py.

🟢 install
Check ID Status
install-pkg-guardian success

These checks are required after the changes to src/lightning/pytorch/loggers/neptune.py.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@SiddhantSadangi SiddhantSadangi added the enhancement New feature or request label Jul 25, 2025
@SiddhantSadangi SiddhantSadangi requested a review from Copilot July 25, 2025 12:44
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies the log_hyperparameters() method in the Neptune logger by replacing manual flattening logic with Neptune's built-in flatten=True and cast_unsupported=True parameters. It also updates the minimum version requirement for neptune-scale to 0.18.0.

  • Replaces custom dictionary flattening implementation with Neptune's native flattening capability
  • Updates neptune-scale minimum version requirement to 0.18.0
  • Removes redundant datetime import and custom type handling logic
Comments suppressed due to low confidence (1)

src/lightning/pytorch/loggers/neptune.py:45

  • The version constraint neptune-scale>=0.18.0 should be verified to ensure this version exists and supports the flatten and cast_unsupported parameters used in the updated code.
_NEPTUNE_SCALE_AVAILABLE = RequirementCache("neptune-scale>=0.18.0")

@SiddhantSadangi SiddhantSadangi merged commit d63f959 into master Jul 25, 2025
64 of 71 checks passed
@SiddhantSadangi SiddhantSadangi deleted the ss/log_hyperaparams branch July 25, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants