Skip to content

Conversation

@QuanMPhm
Copy link
Contributor

@QuanMPhm QuanMPhm commented Mar 7, 2025

While submitting the PR to upgrade the Python version in our CI to 3.12 (#48). Several workflows have failed. The causes of these (as far as I could tell) were:

  • For unit tests, due to an update to the test base in coldfront_plugin_cloud, a function call in one of our unit tests became out-of-date
  • For functional tests, our Keycloak client code no longer seemed to work because of breaking changes introduced in the latest version of the Keycloak image. Pinning the version of the Keycloak image to the one before this repo's last CI check will allow the functional test to pass. @knikolla @larsks @naved001 Is it fine to pin the keycloak container version? I have not added the pin in this PR

@QuanMPhm QuanMPhm requested review from knikolla, larsks and naved001 March 7, 2025 15:53
@QuanMPhm QuanMPhm mentioned this pull request Mar 7, 2025
@naved001
Copy link
Contributor

Is it fine to pin the keycloak container version?

I think that's okay to do to unblock the CI. Do you know how much work would it to be fix our keycloak client code to work with the latest image? You should probably open an issue for that.

@QuanMPhm
Copy link
Contributor Author

QuanMPhm commented Mar 20, 2025

@naved001 I have no idea :P. I'm happy to do some investigative work though. This will be a first for me to do something like this.

I've written up the issue here.

@QuanMPhm
Copy link
Contributor Author

I've added the pin to unblock the CI tests for now

@knikolla knikolla merged commit 3c26eca into nerc-project:main Mar 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants