-
Notifications
You must be signed in to change notification settings - Fork 13
Remove python 3.9 checks from CI tests #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from minor comments below, your commit message needs to be amended. We're removing testing for 3.9 not (directly) because we want to use the latest version of nerc_rates, but because all our other tools (i.e coldfront-plugin-api) has finished migrating to 3.12. Therefore, it is now 'safe' for us to remove testing for 3.9, since we know all our tools should now all work on 3.12
ab67d11 to
c01fdb6
Compare
|
@QuanMPhm changes are done |
c01fdb6 to
a8d764d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your commit message summary is very long. This can cause reading issues on certain GUIs or terminals. As a general rule, try to keep the line length of your commit messages before 80 characters. You can check the commit messages in this repo as an example.
Aside from that, this looks good. @knikolla Just like a quick pass from you. Should the CI files have py312 in their names?
9e68528 to
72b7d65
Compare
done |
Removed because of successful tool migration to python 3.12.
72b7d65 to
1d242e7
Compare
Closes #217. Removed because of successful tool migration to python 3.12.