Skip to content

Conversation

@KelvinLinBU
Copy link
Member

@KelvinLinBU KelvinLinBU commented May 8, 2025

Closes #217. Removed because of successful tool migration to python 3.12.

@KelvinLinBU KelvinLinBU marked this pull request as ready for review May 8, 2025 15:09
@KelvinLinBU KelvinLinBU closed this May 8, 2025
@KelvinLinBU KelvinLinBU reopened this May 8, 2025
@KelvinLinBU KelvinLinBU closed this May 8, 2025
@KelvinLinBU KelvinLinBU reopened this May 8, 2025
@QuanMPhm QuanMPhm self-requested a review May 8, 2025 15:23
Copy link
Contributor

@QuanMPhm QuanMPhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from minor comments below, your commit message needs to be amended. We're removing testing for 3.9 not (directly) because we want to use the latest version of nerc_rates, but because all our other tools (i.e coldfront-plugin-api) has finished migrating to 3.12. Therefore, it is now 'safe' for us to remove testing for 3.9, since we know all our tools should now all work on 3.12

@QuanMPhm QuanMPhm requested review from knikolla and removed request for knikolla May 8, 2025 15:31
@KelvinLinBU
Copy link
Member Author

@QuanMPhm changes are done

Copy link
Contributor

@QuanMPhm QuanMPhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your commit message summary is very long. This can cause reading issues on certain GUIs or terminals. As a general rule, try to keep the line length of your commit messages before 80 characters. You can check the commit messages in this repo as an example.

Aside from that, this looks good. @knikolla Just like a quick pass from you. Should the CI files have py312 in their names?

@QuanMPhm QuanMPhm requested a review from knikolla May 9, 2025 00:27
@KelvinLinBU KelvinLinBU force-pushed the updatepyversion branch 2 times, most recently from 9e68528 to 72b7d65 Compare May 9, 2025 12:30
@KelvinLinBU
Copy link
Member Author

Your commit message summary is very long. This can cause reading issues on certain GUIs or terminals. As a general rule, try to keep the line length of your commit messages before 80 characters. You can check the commit messages in this repo as an example.

Aside from that, this looks good. @knikolla Just like a quick pass from you. Should the CI files have py312 in their names?

done

Removed because of successful tool migration to python 3.12.
@QuanMPhm QuanMPhm merged commit ac89456 into nerc-project:main May 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove outdated Python 3.9 CI tests

3 participants